fix: multiple chat reports picked for onboarding #45785

pac-guerreiro · 2024-07-19T15:13:34Z

cc @rojiphil @chiragsalian @trjExpensify

Details

Fixed Issues

$#45238
PROPOSAL:

The changes introduced in this PR caused a new issue where both concierge and Expensify chat rooms could be picked for onboarding purposes.

This fix aims at fixing this issue and ensuring that for new user accounts, we use the onboarding.chatReportID, and for older accounts, we test if the user's accountID is odd to decide which chat room is used for onboarding.

Tests

On web, while on the homepage write this on the browser console:

Onyx.multiSet({
      ‘nvp_private_firstDayFreeTrial’: <TODAY>,
      ‘nvp_private_lastDayFreeTrial’: <6 DAYS FROM NOW>,
      ‘nvp_onboarding’: {
            hasCompletedGuidedSetupFlow: true,
            chatReportID: <ID OF THE REPORT YOU WANT TO PICK>
      }
});

Replace <TODAY> with today date and <6 DAYS FROM NOW> with the date from 6 days from now, in yyyy-MM-dd HH:mm:ss format.
Replace <ID OF THE REPORT YOU WANT TO PICK> with the ID you extract from the report page URL.

After writing and pressing enter on the keyboard, verify that the Free trial badge is shown in the right LHN item and there’s only one item showing the badge

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-19T15:13:39Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2024-07-24T17:25:05Z

@rojiphil @chiragsalian can you review this?

src/libs/ReportUtils.ts

rojiphil

Looks like that's it here. Once @pac-guerreiro makes the changes I will complete the checklist. Also, the jest runner workflow is likely to fall in line once we make these changes.

src/libs/ReportUtils.ts

…ed-for-onboarding

pac-guerreiro · 2024-07-29T16:27:45Z

@rojiphil @chiragsalian sorry for the delay! I just applied your suggestions, thanks! 😄

rojiphil · 2024-07-31T13:27:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

45785-web-safari.mp4

MacOS: Desktop

45785-desktop.mp4

iOS: mWeb Safari

45785-mweb-safari.mp4

Android: Native

45785-android-native.mp4

Android: mWeb Chrome

45785-mweb-chrome.mp4

iOS: Native

45785-ios-native.mp4

rojiphil

Thanks @pac-guerreiro for the changes. Just one comment though that we need to add a test case for QA.
Otherwise, works well and completed the checklist.
@chiragsalian All yours for final review

chiragsalian

LGTM. Once you add test steps for QA ill merge. Let me know if you need any help with it.

pac-guerreiro · 2024-08-01T17:13:21Z

@chiragsalian sorry for the delay, I just added the test steps you required!

OSBotify · 2024-08-01T19:11:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-02T01:42:08Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.0.16-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-06T04:02:19Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: multiple chat reports picked for onboarding

3624a4a

pac-guerreiro requested a review from a team as a code owner July 19, 2024 15:13

melvin-bot bot requested review from rojiphil and removed request for a team July 19, 2024 15:13

trjExpensify mentioned this pull request Jul 24, 2024

[HOLD for payment 2024-08-13] [Free Trial] [FE] Getting onboarding chat reportID from nvp #45238

Closed

chiragsalian requested changes Jul 24, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

chiragsalian requested changes Jul 24, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

rojiphil reviewed Jul 24, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

pac-guerreiro added 2 commits July 29, 2024 17:15

Merge branch 'main' into pac-guerreiro/fix/multiple-chat-reports-pick…

370c28b

…ed-for-onboarding

fix: apply suggestions

57091ea

pac-guerreiro requested review from rojiphil and chiragsalian July 29, 2024 16:27

rojiphil approved these changes Jul 31, 2024

View reviewed changes

chiragsalian approved these changes Jul 31, 2024

View reviewed changes

chiragsalian merged commit 0c49141 into Expensify:main Aug 1, 2024
16 checks passed

github-actions bot mentioned this pull request Aug 2, 2024

Deploy Checklist: New Expensify 2024-08-02 #46687

Closed

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: multiple chat reports picked for onboarding #45785

fix: multiple chat reports picked for onboarding #45785

pac-guerreiro commented Jul 19, 2024 •

edited

Loading

melvin-bot bot commented Jul 19, 2024

trjExpensify commented Jul 24, 2024

rojiphil left a comment

pac-guerreiro commented Jul 29, 2024

rojiphil commented Jul 31, 2024

rojiphil left a comment

chiragsalian left a comment

pac-guerreiro commented Aug 1, 2024

OSBotify commented Aug 1, 2024

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

fix: multiple chat reports picked for onboarding #45785

fix: multiple chat reports picked for onboarding #45785

Conversation

pac-guerreiro commented Jul 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 19, 2024

trjExpensify commented Jul 24, 2024

rojiphil left a comment

Choose a reason for hiding this comment

pac-guerreiro commented Jul 29, 2024

rojiphil commented Jul 31, 2024

Reviewer Checklist

Screenshots/Videos

rojiphil left a comment

Choose a reason for hiding this comment

chiragsalian left a comment

Choose a reason for hiding this comment

pac-guerreiro commented Aug 1, 2024

OSBotify commented Aug 1, 2024

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

pac-guerreiro commented Jul 19, 2024 •

edited

Loading